qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC 0/3] nRF51 SoC: Add UART support


From: Philippe Mathieu-Daudé
Subject: Re: [Qemu-devel] [RFC 0/3] nRF51 SoC: Add UART support
Date: Tue, 29 May 2018 23:57:47 -0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0

Hi Julia,

On 05/29/2018 07:03 PM, Julia Suvorova via Qemu-devel wrote:
> This series adds basic support for the nRF51 SoC UART, that used in
> BBC Micro:bit board, and QTest for it.
> 
> Based-on: <address@hidden>
> 
> Julia Suvorova (3):
>   hw/arm/nrf51_soc: Fix compilation and memory regions

Since Joel's series isn't merged, you can simply take his patches, fix
them, and include them in your following series.  Usually you keep his
Signed-off-by line, add a comment with your changes, then add your
S-o-b, such:

    [PATCH ...] hw/arm: Add Nordic Semiconductor nRF51 SoC

    The nRF51 is a Cortex-M0 microcontroller with an on-board radio module,
    plus other common ARM SoC peripherals.

    This defines a basic model of the CPU and memory, with no peripherals
    implemented at this stage.

    Signed-off-by: Joel Stanley <address@hidden>
    [Julia: Fixed BBC Micro:bit board ROM/RAM size, added FICR defines]
    Signed-off-by: Julia Suvorova <address@hidden>

>   hw/char/nrf51_uart: Implement nRF51 SoC UART
>   tests/boot-serial-test: Add support for the microbit board
> 
>  hw/arm/nrf51_soc.c           |  19 ++-
>  hw/char/Makefile.objs        |   1 +
>  hw/char/nrf51_uart.c         | 232 +++++++++++++++++++++++++++++++++++
>  include/hw/arm/nrf51_soc.h   |   2 +
>  include/hw/char/nrf51_uart.h |  54 ++++++++
>  tests/boot-serial-test.c     |  11 ++
>  6 files changed, 314 insertions(+), 5 deletions(-)
>  create mode 100644 hw/char/nrf51_uart.c
>  create mode 100644 include/hw/char/nrf51_uart.h
> 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]