Re: [Qemu-devel] [PATCH 00/15] linux-user: move more definitions out of syscall_defs.h

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH 00/15] linux-user: move more definitions out of 
syscall_defs.h

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
7664c3b117 linux-user: remove useless #if
6bed184748 linux-user: move hppa signal definitions to hppa/target_signal.h
ed515ab0ec linux-user: move alpha signal definitions to alpha/target_signal.h
70e99a6a3f linux-user: move openrisc signal definitions to 
openrisc/target_signal.h
7adbcb0f7c linux-user: move mips signal definitions to mips/target_signal.h
2961f1351f linux-user: move sparc signal definitions to sparc/target_signal.h
19c4678fd3 linux-user: move generic signal definitions to generic/signal.h
64dac276ac linux-user: move get_sp_from_cpustate() to target_cpu.h
bbb8662347 linux-user: move sparc/sparc64 fcntl definitions to 
sparc/target_fcntl.h
d641da5d83 linux-user: move ppc fcntl definitions to ppc/target_fcntl.h
e0d745d53d linux-user: move mips/mips64 fcntl definitions to mips/target_fcntl.h
05636c42ee linux-user: move arm/aarch64/m68k fcntl definitions to 
[arm|aarch64|m68k]/target_fcntl.h
09c2218ac0 linux-user: move hppa fcntl definitions to hppa/target_fcntl.h
57851158b7 linux-user: move alpha fcntl definitions to alpha/target_fcntl.h
3911ac1735 linux-user: move generic fcntl definitions to generic/fcntl.h

=== OUTPUT BEGIN ===
Checking PATCH 1/15: linux-user: move generic fcntl definitions to 
generic/fcntl.h...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#14: 
new file mode 100644

total: 0 errors, 1 warnings, 528 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 2/15: linux-user: move alpha fcntl definitions to 
alpha/target_fcntl.h...
Checking PATCH 3/15: linux-user: move hppa fcntl definitions to 
hppa/target_fcntl.h...
Checking PATCH 4/15: linux-user: move arm/aarch64/m68k fcntl definitions to 
[arm|aarch64|m68k]/target_fcntl.h...
Checking PATCH 5/15: linux-user: move mips/mips64 fcntl definitions to 
mips/target_fcntl.h...
ERROR: space prohibited between function name and open parenthesis '('
#98: FILE: linux-user/syscall_defs.h:2429:
+#if defined (TARGET_PPC)

total: 1 errors, 0 warnings, 87 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 6/15: linux-user: move ppc fcntl definitions to 
ppc/target_fcntl.h...
ERROR: space prohibited between function name and open parenthesis '('
#41: FILE: linux-user/syscall_defs.h:2429:
+#if defined (TARGET_SPARC)

total: 1 errors, 0 warnings, 24 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 7/15: linux-user: move sparc/sparc64 fcntl definitions to 
sparc/target_fcntl.h...
Checking PATCH 8/15: linux-user: move get_sp_from_cpustate() to target_cpu.h...
Checking PATCH 9/15: linux-user: move generic signal definitions to 
generic/signal.h...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#49: 
new file mode 100644

total: 0 errors, 1 warnings, 219 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 10/15: linux-user: move sparc signal definitions to 
sparc/target_signal.h...
Checking PATCH 11/15: linux-user: move mips signal definitions to 
mips/target_signal.h...
WARNING: line over 80 characters
#40: FILE: linux-user/mips/target_signal.h:24:
+#define TARGET_SIGCLD           TARGET_SIGCHLD  /* Same as TARGET_SIGCHLD 
(System V).  */

WARNING: line over 80 characters
#43: FILE: linux-user/mips/target_signal.h:27:
+#define TARGET_SIGURG           21      /* Urgent condition on socket (4.2 
BSD).  */

WARNING: line over 80 characters
#45: FILE: linux-user/mips/target_signal.h:29:
+#define TARGET_SIGPOLL          TARGET_SIGIO    /* Pollable event occurred 
(System V).  */

WARNING: line over 80 characters
#54: FILE: linux-user/mips/target_signal.h:38:
+#define TARGET_SIGXFSZ          31      /* File size limit exceeded (4.2 BSD). 
 */

WARNING: line over 80 characters
#108: FILE: linux-user/mips64/target_signal.h:24:
+#define TARGET_SIGCLD           TARGET_SIGCHLD  /* Same as TARGET_SIGCHLD 
(System V).  */

WARNING: line over 80 characters
#111: FILE: linux-user/mips64/target_signal.h:27:
+#define TARGET_SIGURG           21      /* Urgent condition on socket (4.2 
BSD).  */

WARNING: line over 80 characters
#113: FILE: linux-user/mips64/target_signal.h:29:
+#define TARGET_SIGPOLL          TARGET_SIGIO    /* Pollable event occurred 
(System V).  */

WARNING: line over 80 characters
#122: FILE: linux-user/mips64/target_signal.h:38:
+#define TARGET_SIGXFSZ          31      /* File size limit exceeded (4.2 BSD). 
 */

total: 0 errors, 8 warnings, 191 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 12/15: linux-user: move openrisc signal definitions to 
openrisc/target_signal.h...
Checking PATCH 13/15: linux-user: move alpha signal definitions to 
alpha/target_signal.h...
Checking PATCH 14/15: linux-user: move hppa signal definitions to 
hppa/target_signal.h...
Checking PATCH 15/15: linux-user: remove useless #if...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden