[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v4 12/19] timer: remove replay clock probe in deadli
From: |
Pavel Dovgalyuk |
Subject: |
[Qemu-devel] [PATCH v4 12/19] timer: remove replay clock probe in deadline calculation |
Date: |
Mon, 28 May 2018 10:14:41 +0300 |
User-agent: |
StGit/0.17.1-dirty |
Ciro Santilli reported that commit a5ed352596a8b7eb2f9acce34371b944ac3056c4
breaks the execution replay. It happens due to the probing the clock
for the new instances of iothread.
However, this probing was made in replay mode for the timer lists that
are empty.
This patch removes clock probing in replay mode.
It is an artifact of the old version with another thread model.
Signed-off-by: Pavel Dovgalyuk <address@hidden>
---
util/qemu-timer.c | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/util/qemu-timer.c b/util/qemu-timer.c
index 2ed1bf2..86bfe84 100644
--- a/util/qemu-timer.c
+++ b/util/qemu-timer.c
@@ -578,17 +578,10 @@ int64_t timerlistgroup_deadline_ns(QEMUTimerListGroup
*tlg)
{
int64_t deadline = -1;
QEMUClockType type;
- bool play = replay_mode == REPLAY_MODE_PLAY;
for (type = 0; type < QEMU_CLOCK_MAX; type++) {
if (qemu_clock_use_for_deadline(type)) {
- if (!play || type == QEMU_CLOCK_REALTIME) {
- deadline = qemu_soonest_timeout(deadline,
-
timerlist_deadline_ns(tlg->tl[type]));
- } else {
- /* Read clock from the replay file and
- do not calculate the deadline, based on virtual clock. */
- qemu_clock_get_ns(type);
- }
+ deadline = qemu_soonest_timeout(deadline,
+
timerlist_deadline_ns(tlg->tl[type]));
}
}
return deadline;
- [Qemu-devel] [PATCH v4 02/19] replay: disable default snapshot for record/replay, (continued)
- [Qemu-devel] [PATCH v4 02/19] replay: disable default snapshot for record/replay, Pavel Dovgalyuk, 2018/05/28
- [Qemu-devel] [PATCH v4 03/19] replay: update docs for record/replay with block devices, Pavel Dovgalyuk, 2018/05/28
- [Qemu-devel] [PATCH v4 04/19] replay: don't drain/flush bdrv queue while RR is working, Pavel Dovgalyuk, 2018/05/28
- [Qemu-devel] [PATCH v4 06/19] qcow2: introduce icount field for snapshots, Pavel Dovgalyuk, 2018/05/28
- [Qemu-devel] [PATCH v4 05/19] replay: finish record/replay before closing the disks, Pavel Dovgalyuk, 2018/05/28
- [Qemu-devel] [PATCH v4 07/19] migration: introduce icount field for snapshots, Pavel Dovgalyuk, 2018/05/28
- [Qemu-devel] [PATCH v4 08/19] replay: introduce info hmp/qmp command, Pavel Dovgalyuk, 2018/05/28
- [Qemu-devel] [PATCH v4 09/19] replay: introduce breakpoint at the specified step, Pavel Dovgalyuk, 2018/05/28
- [Qemu-devel] [PATCH v4 10/19] replay: implement replay-seek command to proceed to the desired step, Pavel Dovgalyuk, 2018/05/28
- [Qemu-devel] [PATCH v4 11/19] replay: flush events when exiting, Pavel Dovgalyuk, 2018/05/28
- [Qemu-devel] [PATCH v4 12/19] timer: remove replay clock probe in deadline calculation,
Pavel Dovgalyuk <=
- [Qemu-devel] [PATCH v4 13/19] replay: refine replay-time module, Pavel Dovgalyuk, 2018/05/28
- [Qemu-devel] [PATCH v4 14/19] translator: fix breakpoint processing, Pavel Dovgalyuk, 2018/05/28
- [Qemu-devel] [PATCH v4 15/19] replay: flush rr queue before loading the vmstate, Pavel Dovgalyuk, 2018/05/28
- [Qemu-devel] [PATCH v4 16/19] gdbstub: add reverse step support in replay mode, Pavel Dovgalyuk, 2018/05/28
- [Qemu-devel] [PATCH v4 17/19] gdbstub: add reverse continue support in replay mode, Pavel Dovgalyuk, 2018/05/28
- [Qemu-devel] [PATCH v4 18/19] replay: describe reverse debugging in docs/replay.txt, Pavel Dovgalyuk, 2018/05/28
- [Qemu-devel] [PATCH v4 19/19] replay: allow loading any snapshots before recording, Pavel Dovgalyuk, 2018/05/28