[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 01/13] 9p: linux: Fix a couple Linux assumptions

From: Keno Fischer
Subject: Re: [Qemu-devel] [PATCH 01/13] 9p: linux: Fix a couple Linux assumptions
Date: Sat, 26 May 2018 12:17:08 -0400

>>> diff --git a/fsdev/file-op-9p.h b/fsdev/file-op-9p.h
>>> index 3fa062b..a13e729 100644
>>> --- a/fsdev/file-op-9p.h
>>> +++ b/fsdev/file-op-9p.h
>>> @@ -16,7 +16,9 @@
>>>  #include <dirent.h>
>>>  #include <utime.h>
>>> +#ifdef CONFIG_LINUX
>> What about a less restrictive:
>> #ifndef __APPLE__
> In general I would recommend checking for specific
> features (usually in configure), rather than adding
> ifdef tests for particular OSes. In this case presumably
> we're including these headers because we're after
> a specific function or define or whatever, so we can
> check in configure for what header that's in (or
> if it's not available at all).
> thanks
> -- PMM

This header is used for struct statfs. I would be fine
with a configure check for this, though it looks like
other places in the code base that use this header
(e.g. util/mmap-alloc.c) also guard it in
CONFIG_LINUX, so that seemed like the right check
to me given the current code base.

Would you like me to submit a patch to switch these
to a configure check?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]