Re: [Qemu-devel] [PATCH v2 04/20] migration: drop an unused include

[Eric Blake]

On 05/25/2018 11:47 AM, Michael S. Tsirkin wrote:
> we just need a struct name, let's add a forward
> declaration instead of an include.
>
> Signed-off-by: Michael S. Tsirkin <address@hidden>
> ---
>   include/migration/vmstate.h | 2 +-
>   migration/savevm.c          | 1 +
>   2 files changed, 2 insertions(+), 1 deletion(-)

I'm okay with the patch as-is, but the commit message could possibly be 
improved:

In the vmstate.h file, we just need a struct name. Use a forward 
declaration instead of an include, then adjust the one affected .c file 
to include the file that is no longer implicit from the header.

Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org