[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 03/13] linux-user: update comments to point to tcg_ex
From: |
Laurent Vivier |
Subject: |
[Qemu-devel] [PULL 03/13] linux-user: update comments to point to tcg_exec_init() |
Date: |
Fri, 25 May 2018 10:17:44 +0200 |
From: Igor Mammedov <address@hidden>
cpu_init() was replaced by cpu_create() since 2.12 but comments
weren't updated. So update stale comments to point that page
sizes arei actually initialized by tcg_exec_init(). Also move
another qemu_host_page_size related comment before tcg_exec_init()
where it belongs.
Signed-off-by: Igor Mammedov <address@hidden>
Reviewed-by: Laurent Vivier <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
---
bsd-user/main.c | 7 ++++---
linux-user/main.c | 5 ++---
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/bsd-user/main.c b/bsd-user/main.c
index 283dc6fd25..da3b833975 100644
--- a/bsd-user/main.c
+++ b/bsd-user/main.c
@@ -898,9 +898,10 @@ int main(int argc, char **argv)
cpu_model = "any";
#endif
}
+
+ /* init tcg before creating CPUs and to get qemu_host_page_size */
tcg_exec_init(0);
- /* NOTE: we need to init the CPU at this stage to get
- qemu_host_page_size */
+
cpu_type = parse_cpu_model(cpu_model);
cpu = cpu_create(cpu_type);
env = cpu->env_ptr;
@@ -917,7 +918,7 @@ int main(int argc, char **argv)
envlist_free(envlist);
/*
- * Now that page sizes are configured in cpu_init() we can do
+ * Now that page sizes are configured in tcg_exec_init() we can do
* proper page alignment for guest_base.
*/
guest_base = HOST_PAGE_ALIGN(guest_base);
diff --git a/linux-user/main.c b/linux-user/main.c
index 32347545c9..78d6d3e7eb 100644
--- a/linux-user/main.c
+++ b/linux-user/main.c
@@ -671,9 +671,8 @@ int main(int argc, char **argv, char **envp)
}
cpu_type = parse_cpu_model(cpu_model);
+ /* init tcg before creating CPUs and to get qemu_host_page_size */
tcg_exec_init(0);
- /* NOTE: we need to init the CPU at this stage to get
- qemu_host_page_size */
cpu = cpu_create(cpu_type);
env = cpu->env_ptr;
@@ -693,7 +692,7 @@ int main(int argc, char **argv, char **envp)
envlist_free(envlist);
/*
- * Now that page sizes are configured in cpu_init() we can do
+ * Now that page sizes are configured in tcg_exec_init() we can do
* proper page alignment for guest_base.
*/
guest_base = HOST_PAGE_ALIGN(guest_base);
--
2.14.3
- [Qemu-devel] [PULL 00/13] Linux user for 2.13 patches, Laurent Vivier, 2018/05/25
- [Qemu-devel] [PULL 09/13] linux-user: move ppc socket.h definitions to ppc/sockbits.h, Laurent Vivier, 2018/05/25
- [Qemu-devel] [PULL 04/13] linux-user: Fix payload size logic in host_to_target_cmsg(), Laurent Vivier, 2018/05/25
- [Qemu-devel] [PULL 13/13] gdbstub: Clarify what gdb_handlesig() is doing, Laurent Vivier, 2018/05/25
- [Qemu-devel] [PULL 01/13] linux-user: Assert on bad type in thunk_type_align() and thunk_type_size(), Laurent Vivier, 2018/05/25
- [Qemu-devel] [PULL 05/13] linux-user: move mips socket.h definitions to mips/sockbits.h, Laurent Vivier, 2018/05/25
- [Qemu-devel] [PULL 12/13] linux-user: define TARGET_SO_REUSEPORT, Laurent Vivier, 2018/05/25
- [Qemu-devel] [PULL 03/13] linux-user: update comments to point to tcg_exec_init(),
Laurent Vivier <=
- [Qemu-devel] [PULL 06/13] linux-user: move alpha socket.h definitions to alpha/sockbits.h, Laurent Vivier, 2018/05/25
- [Qemu-devel] [PULL 08/13] linux-user: move socket.h generic definitions to generic/sockbits.h, Laurent Vivier, 2018/05/25
- [Qemu-devel] [PULL 02/13] linux-user: update netlink emulation, Laurent Vivier, 2018/05/25
- [Qemu-devel] [PULL 11/13] linux-user: copy sparc/sockbits.h definitions from linux, Laurent Vivier, 2018/05/25
- [Qemu-devel] [PULL 10/13] linux-user: update ARCH_HAS_SOCKET_TYPES use, Laurent Vivier, 2018/05/25
- [Qemu-devel] [PULL 07/13] linux-user: move sparc/sparc64 socket.h definitions to sparc/sockbits.h, Laurent Vivier, 2018/05/25
- Re: [Qemu-devel] [PULL 00/13] Linux user for 2.13 patches, no-reply, 2018/05/25
- Re: [Qemu-devel] [PULL 00/13] Linux user for 2.13 patches, Peter Maydell, 2018/05/25