[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 36/40] job: Add lifecycle QMP commands
From: |
John Snow |
Subject: |
Re: [Qemu-devel] [PATCH v2 36/40] job: Add lifecycle QMP commands |
Date: |
Wed, 23 May 2018 19:56:23 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 05/18/2018 09:21 AM, Kevin Wolf wrote:
> +{ 'command': 'job-complete', 'data': { 'id': 'str' } }
Do we have to name it this? I've always disliked how "complete" is used
as both a verb and an adjective in our code (hence why I used such
bizarre phrasings like "concluded" in my jobs patches) ...
I don't necessarily have a better suggestion, but now's the chance to
ask the question.
I guess you don't have a better suggestion either, otherwise you'd have
changed it.
--js
- [Qemu-devel] [PATCH v2 27/40] job: Move completion and cancellation to Job, (continued)
- [Qemu-devel] [PATCH v2 27/40] job: Move completion and cancellation to Job, Kevin Wolf, 2018/05/18
- [Qemu-devel] [PATCH v2 30/40] job: Add job_dismiss(), Kevin Wolf, 2018/05/18
- [Qemu-devel] [PATCH v2 32/40] job: Add job_transition_to_ready(), Kevin Wolf, 2018/05/18
- [Qemu-devel] [PATCH v2 31/40] job: Add job_is_ready(), Kevin Wolf, 2018/05/18
- [Qemu-devel] [PATCH v2 34/40] job: Introduce qapi/job.json, Kevin Wolf, 2018/05/18
- [Qemu-devel] [PATCH v2 36/40] job: Add lifecycle QMP commands, Kevin Wolf, 2018/05/18
- [Qemu-devel] [PATCH v2 37/40] job: Add query-jobs QMP command, Kevin Wolf, 2018/05/18
- [Qemu-devel] [PATCH v2 33/40] job: Move progress fields to Job, Kevin Wolf, 2018/05/18
- [Qemu-devel] [PATCH v2 39/40] iotests: Move qmp_to_opts() to VM, Kevin Wolf, 2018/05/18
- [Qemu-devel] [PATCH v2 38/40] blockjob: Remove BlockJob.driver, Kevin Wolf, 2018/05/18
- [Qemu-devel] [PATCH v2 40/40] qemu-iotests: Test job-* with block jobs, Kevin Wolf, 2018/05/18
- [Qemu-devel] [PATCH v2 35/40] job: Add JOB_STATUS_CHANGE QMP event, Kevin Wolf, 2018/05/18