[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 5/6] bochs-display: add pcie support
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH v2 5/6] bochs-display: add pcie support |
Date: |
Tue, 22 May 2018 17:52:28 -0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
Hi Gerd,
On 05/22/2018 01:50 PM, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---
> hw/display/bochs-display.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/hw/display/bochs-display.c b/hw/display/bochs-display.c
> index 9607df1c34..c33524b558 100644
> --- a/hw/display/bochs-display.c
> +++ b/hw/display/bochs-display.c
> @@ -253,6 +253,7 @@ static void bochs_display_realize(PCIDevice *dev, Error
> **errp)
> {
> BochsDisplayState *s = BOCHS_DISPLAY(dev);
> Object *obj = OBJECT(dev);
> + int ret;
>
> s->con = graphic_console_init(DEVICE(dev), 0, &bochs_display_gfx_ops, s);
>
> @@ -280,6 +281,12 @@ static void bochs_display_realize(PCIDevice *dev, Error
> **errp)
> pci_register_bar(&s->pci, 0, PCI_BASE_ADDRESS_MEM_PREFETCH, &s->vram);
> pci_register_bar(&s->pci, 2, PCI_BASE_ADDRESS_SPACE_MEMORY, &s->mmio);
>
> + if (pci_bus_is_express(pci_get_bus(dev))) {
> + dev->cap_present |= QEMU_PCI_CAP_EXPRESS;
> + ret = pcie_endpoint_cap_init(dev, 0x80);
> + assert(ret > 0);
Maybe error_setg(errp, ...) && return?
> + }
> +
> memory_region_set_log(&s->vram, true, DIRTY_MEMORY_VGA);
> }
>
> @@ -342,6 +349,7 @@ static const TypeInfo bochs_display_type_info = {
> .instance_init = bochs_display_init,
> .class_init = bochs_display_class_init,
> .interfaces = (InterfaceInfo[]) {
> + { INTERFACE_PCIE_DEVICE },
> { INTERFACE_CONVENTIONAL_PCI_DEVICE },
> { },
> },
>
- [Qemu-devel] [PATCH v2 0/6] display: add new bochs-display device, Gerd Hoffmann, 2018/05/22
- [Qemu-devel] [PATCH v2 6/6] MAINTAINERS: add vga entries, Gerd Hoffmann, 2018/05/22
- [Qemu-devel] [PATCH v2 5/6] bochs-display: add pcie support, Gerd Hoffmann, 2018/05/22
- Re: [Qemu-devel] [PATCH v2 5/6] bochs-display: add pcie support,
Philippe Mathieu-Daudé <=
- [Qemu-devel] [PATCH v2 2/6] vga-pci: use PCI_VGA_MMIO_SIZE, Gerd Hoffmann, 2018/05/22
- [Qemu-devel] [PATCH v2 1/6] vga: move bochs vbe defines to header file, Gerd Hoffmann, 2018/05/22
- [Qemu-devel] [PATCH v2 3/6] hw/display: add new bochs-display device, Gerd Hoffmann, 2018/05/22
- [Qemu-devel] [PATCH v2 4/6] bochs-display: add dirty tracking support, Gerd Hoffmann, 2018/05/22