[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL v2 02/15] xen/pt: use address_space_memory object for
From: |
Stefano Stabellini |
Subject: |
[Qemu-devel] [PULL v2 02/15] xen/pt: use address_space_memory object for memory region hooks |
Date: |
Tue, 22 May 2018 11:46:29 -0700 |
From: Igor Druzhinin <address@hidden>
Commit 99605175c (xen-pt: Fix PCI devices re-attach failed) introduced
a subtle bug. As soon as the guest switches off Bus Mastering on the
device it immediately causes all the BARs be unmapped due to the DMA
address space of the device being changed. This is undesired behavior
because the guest may try to communicate with the device after that
which triggers the following errors in the logs:
[00:05.0] xen_pt_bar_read: Error: Should not read BAR through QEMU.
@0x0000000000000200
[00:05.0] xen_pt_bar_write: Error: Should not write BAR through QEMU.
@0x0000000000000200
The issue that the original patch tried to workaround (uneven number of
region_add/del calls on device attach/detach) was fixed in d25836cafd
(memory: do explicit cleanup when remove listeners).
Signed-off-by: Igor Druzhinin <address@hidden>
Reported-by: Ross Lagerwall <address@hidden>
Acked-by: Anthony PERARD <address@hidden>
Signed-off-by: Stefano Stabellini <address@hidden>
---
hw/xen/xen_pt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c
index 9b7a960..e5a6eff 100644
--- a/hw/xen/xen_pt.c
+++ b/hw/xen/xen_pt.c
@@ -907,7 +907,7 @@ out:
}
}
- memory_listener_register(&s->memory_listener, &s->dev.bus_master_as);
+ memory_listener_register(&s->memory_listener, &address_space_memory);
memory_listener_register(&s->io_listener, &address_space_io);
s->listener_set = true;
XEN_PT_LOG(d,
--
1.9.1
- [Qemu-devel] [PULL v2 00/15] xen-20180522-tag, Stefano Stabellini, 2018/05/22
- [Qemu-devel] [PULL v2 01/15] xen-pvdevice: Introduce a simplistic xen-pvdevice save state, Stefano Stabellini, 2018/05/22
- [Qemu-devel] [PULL v2 02/15] xen/pt: use address_space_memory object for memory region hooks,
Stefano Stabellini <=
- [Qemu-devel] [PULL v2 10/15] xen: remove other open-coded use of libxengnttab, Stefano Stabellini, 2018/05/22
- [Qemu-devel] [PULL v2 15/15] xen_disk: be consistent with use of xendev and blkdev->xendev, Stefano Stabellini, 2018/05/22
- [Qemu-devel] [PULL v2 05/15] xen-hvm: create separate function for ioreq server initialization, Stefano Stabellini, 2018/05/22
- [Qemu-devel] [PULL v2 04/15] xen_pt: Present the size of 64 bit BARs correctly, Stefano Stabellini, 2018/05/22
- [Qemu-devel] [PULL v2 03/15] configure: Add explanation for --enable-xen-pci-passthrough, Stefano Stabellini, 2018/05/22
- [Qemu-devel] [PULL v2 07/15] xen: add a meaningful declaration of grant_copy_segment into xen_common.h, Stefano Stabellini, 2018/05/22
- [Qemu-devel] [PULL v2 11/15] xen_backend: add an emulation of grant copy, Stefano Stabellini, 2018/05/22
- [Qemu-devel] [PULL v2 06/15] checkpatch: generalize xen handle matching in the list of types, Stefano Stabellini, 2018/05/22
- [Qemu-devel] [PULL v2 14/15] xen_disk: use a single entry iovec, Stefano Stabellini, 2018/05/22
- [Qemu-devel] [PULL v2 13/15] xen_backend: make the xen_feature_grant_copy flag private, Stefano Stabellini, 2018/05/22