[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] timer/aspeed: fix vmstate version id

From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH v2] timer/aspeed: fix vmstate version id
Date: Tue, 22 May 2018 18:21:42 +0100

On 2 May 2018 at 14:56, Cédric Le Goater <address@hidden> wrote:
>> There seems to be an issue while reading the CPACR reg.
> With a brutal setting of CPACR in cpu_reset, the romulus-bmc machine
> migrates. What would be a more appropriate approach ?

Ah, yes, the bug here is that we made the cpacr_write() function
insist that certain bits are RAO/WI, but we didn't also change
the reset code to match. So (a) the guest initially reads a
value which doesn't have ones in the RAO bits and (b) when we
migrate we get a mismatch between what we had on the source
end and what we get when we write that to the destination end.

I think we can fix the reset value without having to duplicate
the logic from cpacr_write() using a resetfn. I'll cook up a patch...

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]