[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 05/10] intel-iommu: introduce vtd_page_walk_i
From: |
Auger Eric |
Subject: |
Re: [Qemu-devel] [PATCH v2 05/10] intel-iommu: introduce vtd_page_walk_info |
Date: |
Fri, 18 May 2018 09:24:51 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 |
Hi Peter,
On 05/18/2018 07:59 AM, Peter Xu wrote:
> On Thu, May 17, 2018 at 04:32:58PM +0200, Auger Eric wrote:
>> Hi Peter,
>>
>> On 05/04/2018 05:08 AM, Peter Xu wrote:
>>> During the recursive page walking of IOVA page tables, some stack
>>> variables are constant variables and never changed during the whole page
>>> walking procedure. Isolate them into a struct so that we don't need to
>>> pass those contants down the stack every time and multiple times.
>>>
>>> Signed-off-by: Peter Xu <address@hidden>
>> Reviewed-by: Eric Auger <address@hidden>
>
> Thanks for the r-b, but this patch is changed in version 3. Please
> feel free to have a look at that version.
Sure. Please apologize, I missed your v3. Looking at it now.
Thanks
Eric
>
> (For all the review comments previously to version 2, I adopted them
> when the contents are still there in version 3)
>
> Regards,
>
[Qemu-devel] [PATCH v2 06/10] intel-iommu: pass in address space when page walk, Peter Xu, 2018/05/03
[Qemu-devel] [PATCH v2 07/10] util: implement simple interval tree logic, Peter Xu, 2018/05/03
[Qemu-devel] [PATCH v2 08/10] intel-iommu: maintain per-device iova ranges, Peter Xu, 2018/05/03
[Qemu-devel] [PATCH v2 09/10] intel-iommu: don't unmap all for shadow page table, Peter Xu, 2018/05/03
[Qemu-devel] [PATCH v2 10/10] intel-iommu: remove notify_unmap for page walk, Peter Xu, 2018/05/03