qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 2/5] qemu-options: Bail out on unsupported op


From: Thomas Huth
Subject: Re: [Qemu-devel] [PATCH v2 2/5] qemu-options: Bail out on unsupported options instead of silently ignoring them
Date: Wed, 16 May 2018 18:51:32 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0

On 16.05.2018 18:49, Anthony PERARD wrote:
> On Fri, May 04, 2018 at 07:01:07PM +0200, Thomas Huth wrote:
>> diff --git a/vl.c b/vl.c
>> index 806eec2..457e93b 100644
>> --- a/vl.c
>> +++ b/vl.c
>> @@ -4042,7 +4042,10 @@ int main(int argc, char **argv, char **envp)
>>                  }
>>                  break;
>>              default:
>> -                os_parse_cmd_args(popt->index, optarg);
>> +                if (os_parse_cmd_args(popt->index, optarg)) {
>> +                    error_report("Option not supported in this build");
>> +                    exit(1);
>> +                }
> 
> I think that report false errors, I've got:
> qemu-system-i386: -no-user-config: Option not supported in this build

Yes, sorry for that. Patch is already on the way:

https://lists.gnu.org/archive/html/qemu-devel/2018-05/msg02972.html

 Thomas



reply via email to

[Prev in Thread] Current Thread [Next in Thread]