[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v4] numa: clarify error message when node index is o
From: |
Igor Mammedov |
Subject: |
[Qemu-devel] [PATCH v4] numa: clarify error message when node index is out of range in -numa dist, ... |
Date: |
Wed, 16 May 2018 17:06:14 +0200 |
When using following CLI:
-numa dist,src=128,dst=1,val=20
user gets a rather confusing error message:
"Invalid node 128, max possible could be 128"
Where 128 is number of nodes that QEMU supports (MAX_NODES),
while src/dst is an index up to that limit, so it should be
MAX_NODES - 1 in error message.
Make error message to explicitly state valid range for node
index to be more clear.
Signed-off-by: Igor Mammedov <address@hidden>
---
v4:
- e error message suggested by Markus
v3:
- s/,/./ in error message
- add '.' at the end of sentence
---
numa.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/numa.c b/numa.c
index 188bfdf..33572bf 100644
--- a/numa.c
+++ b/numa.c
@@ -141,9 +141,8 @@ static void parse_numa_distance(NumaDistOptions *dist,
Error **errp)
uint8_t val = dist->val;
if (src >= MAX_NODES || dst >= MAX_NODES) {
- error_setg(errp,
- "Invalid node %d, max possible could be %d",
- MAX(src, dst), MAX_NODES);
+ error_setg(errp, "Parameter '%s' expects an integer between 0 and %d",
+ src >= MAX_NODES ? "src" : "dst", MAX_NODES - 1);
return;
}
--
2.7.4
- [Qemu-devel] [PATCH v4] numa: clarify error message when node index is out of range in -numa dist, ...,
Igor Mammedov <=