[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 28/36] target-microblaze: Add support for ext
From: |
Edgar E. Iglesias |
Subject: |
Re: [Qemu-devel] [PATCH v2 28/36] target-microblaze: Add support for extended access to TLBLO |
Date: |
Wed, 16 May 2018 00:23:52 +0200 |
User-agent: |
NeoMutt/20170609 (1.8.3) |
On Wed, May 09, 2018 at 02:15:14PM -0700, Richard Henderson wrote:
> On 05/08/2018 10:31 AM, Edgar E. Iglesias wrote:
> > + if (to) {
> > + gen_helper_mmu_write(cpu_env, tcg_const_i32(extended),
> > + tcg_const_i32(sr), cpu_R[dc->ra]);
> > + } else {
> > + gen_helper_mmu_read(cpu_R[dc->rd], cpu_env,
> > + tcg_const_i32(extended),
> > tcg_const_i32(sr));
> > + }
>
> These tcg_const_i32 results should be tcg_temp_free'd.
Thanks, I've fixed this for v3.
- Re: [Qemu-devel] [PATCH v2 25/36] target-microblaze: mmu: Remove unused register state, (continued)
- [Qemu-devel] [PATCH v2 26/36] target-microblaze: mmu: Prepare for 64-bit addresses, Edgar E. Iglesias, 2018/05/08
- [Qemu-devel] [PATCH v2 24/36] target-microblaze: mmu: Add R_TBLX_MISS macros, Edgar E. Iglesias, 2018/05/08
- [Qemu-devel] [PATCH v2 27/36] target-microblaze: mmu: Add a configurable output address mask, Edgar E. Iglesias, 2018/05/08
- [Qemu-devel] [PATCH v2 29/36] target-microblaze: Allow address sizes between 32 and 64 bits, Edgar E. Iglesias, 2018/05/08
- [Qemu-devel] [PATCH v2 28/36] target-microblaze: Add support for extended access to TLBLO, Edgar E. Iglesias, 2018/05/08
- [Qemu-devel] [PATCH v2 30/36] target-microblaze: Simplify address computation using tcg_gen_addi_i32(), Edgar E. Iglesias, 2018/05/08
- [Qemu-devel] [PATCH v2 33/36] target-microblaze: Remove argument b in eval_cc(), Edgar E. Iglesias, 2018/05/08
- [Qemu-devel] [PATCH v2 32/36] target-microblaze: Use table based condition-codes conversion, Edgar E. Iglesias, 2018/05/08
- [Qemu-devel] [PATCH v2 31/36] target-microblaze: mmu: Cleanup debug log messages, Edgar E. Iglesias, 2018/05/08
- [Qemu-devel] [PATCH v2 35/36] target-microblaze: Convert env_btarget to i64, Edgar E. Iglesias, 2018/05/08