Re: [Qemu-devel] [PATCH RFC] qemu-error: introduce error_report_once

[Eric Blake]

On 05/15/2018 10:56 AM, Markus Armbruster wrote:

> > One example I can think of is that we can keep some error environment
> > when the first error happens:
> >
> >    if (something_wrong_happened) {
> >       if (error_report_once("blablabla")) {
> >         /* only cache the first error */
> >         error_cmd = xxx;
> >         error_param = xxx;
> >         ...
> >       }
> >    }
>
> I see.
>
> Add a contract comment (suggest to start with the one next to
> error_report()), expand the tabs, replace the reserved identifiers
> (caught by patchew; you can use foo_ instead of __foo),

Actually, patchew doesn't flag use of leading __ (although maybe it 
should); it was complaining about the use of TAB instead of space.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org