[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 02/18] memory-device: introduce se

From: Eric Blake
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 02/18] memory-device: introduce separate config option
Date: Tue, 15 May 2018 10:21:26 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0

On 05/14/2018 07:20 PM, Murilo Opsfelder Araujo wrote:
On Mon, May 14, 2018 at 12:00:07PM +0200, David Hildenbrand wrote:
Some architectures might support memory devices, while they don't
support DIMM/NVDIMM. So let's
- Intriduce CONFIG_DIMM and use it similarly to CONFIG NVDIMM

Since you're resending it:


+++ b/qapi/misc.json
@@ -2060,7 +2060,7 @@
  # @plugged-memory: size of memory that can be hot-unplugged. This field
  #                  is omitted if target doesn't support memory hotplug
-#                  (i.e. CONFIG_MEM_HOTPLUG not defined on build time).
+#                  (i.e. CONFIG_MEM_DEVICE not defined on build time).

Also, it sounds better with: s/on/at/

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]