[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH qemu v2] qom: Document qom/device-list-propertie
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH qemu v2] qom: Document qom/device-list-properties implementation specific |
Date: |
Tue, 15 May 2018 14:31:32 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 15/05/2018 14:07, Markus Armbruster wrote:
> Alexey Kardashevskiy <address@hidden> writes:
>
>> The recently introduced qom-list-properties QMP command raised
>> a question what properties it (and its cousin - device-list-properties)
>> can possibly print - only those defined by DeviceClass::props
>> or dynamically created in TypeInfo::instance_init() so properties created
>> elsewhere won't show up and this behaviour might confuse the user.
>> For example, PIIX4 does that from piix4_pm_realize():
>>
>> hw/acpi/piix4.c|477| object_property_add_uint8_ptr(OBJECT(s),
>> ACPI_PM_PROP_ACPI_ENABLE_CMD,
>
> I'd like to tweak this to
>
> For example, PIIX4 does that from piix4_pm_realize() via
> piix4_pm_add_propeties():
>
> object_property_add_uint8_ptr(OBJECT(s), ACPI_PM_PROP_ACPI_ENABLE_CMD,
> &acpi_enable_cmd, NULL);
>
> if you don't mind.
>
>> This adds a note to the command descriptions about the limitation.
>>
>> Signed-off-by: Alexey Kardashevskiy <address@hidden>
>
> Thanks!
>
> Reviewed-by: Markus Armbruster <address@hidden>
>
Acked-by: Paolo Bonzini <address@hidden>
Thanks,
Paolo