Re: [Qemu-devel] [PATCH v2 02/27] fpu/softfloat: Don't set Invalid for float-to-int(MAXINT)

[Richard Henderson]

On 05/14/2018 03:19 AM, Peter Maydell wrote:
> On 12 May 2018 at 01:42, Richard Henderson <address@hidden> wrote:
>> From: Peter Maydell <address@hidden>
>>
>> In float-to-integer conversion, if the floating point input
>> converts exactly to the largest or smallest integer that
>> fits in to the result type, this is not an overflow.
>> In this situation we were producing the correct result value,
>> but were incorrectly setting the Invalid flag.
>> For example for Arm A64, "FCVTAS w0, d0" on an input of
>> 0x41dfffffffc00000 should produce 0x7fffffff and set no flags.
>>
>> Fix the boundary case to take the right half of the if()
>> statements.
>>
>> This fixes a regression from 2.11 introduced by the softfloat
>> refactoring.
>>
>> Cc: address@hidden
>> Fixes: ab52f973a50
>> Signed-off-by: Peter Maydell <address@hidden>
> 
> This is missing your Signed-off-by: line (and a reviewed-by
> would be nice too :-))

Dang it.  I thought I had done so for all of the patches.
Clearly missed one though.  For your target-arm.next branch:

Reviewed-by: Richard Henderson <address@hidden>


r~