[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 03/42] blockjob: Move RateLimit to BlockJob
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH 03/42] blockjob: Move RateLimit to BlockJob |
Date: |
Sat, 12 May 2018 00:14:02 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 2018-05-09 18:25, Kevin Wolf wrote:
> Every block job has a RateLimit, and they all do the exact same thing
> with it, so it should be common infrastructure. Move the struct field
> for a start.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> ---
> include/block/blockjob.h | 4 ++++
> block/backup.c | 5 ++---
> block/commit.c | 5 ++---
> block/mirror.c | 6 +++---
> block/stream.c | 5 ++---
> 5 files changed, 13 insertions(+), 12 deletions(-)
Instead of finally getting rid of block job throttling, you make it
central functionality? Bah, I say, bah! ;-)
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 00/42] Generic background jobs, Kevin Wolf, 2018/05/09
- [Qemu-devel] [PATCH 01/42] blockjob: Fix assertion in block_job_finalize(), Kevin Wolf, 2018/05/09
- [Qemu-devel] [PATCH 02/42] blockjob: Wrappers for progress counter access, Kevin Wolf, 2018/05/09
- [Qemu-devel] [PATCH 03/42] blockjob: Move RateLimit to BlockJob, Kevin Wolf, 2018/05/09
- [Qemu-devel] [PATCH 07/42] blockjob: Remove block_job_pause/resume_all(), Kevin Wolf, 2018/05/09
- [Qemu-devel] [PATCH 04/42] blockjob: Implement block_job_set_speed() centrally, Kevin Wolf, 2018/05/09
- [Qemu-devel] [PATCH 05/42] blockjob: Introduce block_job_ratelimit_get_delay(), Kevin Wolf, 2018/05/09