[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] qcow2: fix preallocation with metadata on ba
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v2] qcow2: fix preallocation with metadata on bare block device |
|
Date: |
Fri, 11 May 2018 08:41:27 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 05/11/2018 07:37 AM, Ivan Ren wrote:
Create a qcow2 directly on bare block device with
"-o preallocation=metadata" option. When read this qcow2, it will
return pre-existing data on block device, and this may lead to
data leakage. This patch add QCOW_OFLAG_ZERO for all preallocated
l2 entry to avoid this problem.
This is a semantic change; are we okay making it?
Does your code properly check for qcow2v2 files, which don't support
QCOW_OFLAG_ZERO (only qcow2v3 supports it)?
Signed-off-by: Ivan Ren <address@hidden>
---
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org