[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] tcg: Optionally log FPU state in TCG -d cpu log
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH] tcg: Optionally log FPU state in TCG -d cpu logging |
Date: |
Fri, 11 May 2018 12:00:54 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 10/05/2018 16:38, Peter Maydell wrote:
> On 10 May 2018 at 15:36, Richard Henderson <address@hidden> wrote:
>> On 05/10/2018 06:00 AM, Peter Maydell wrote:
>>> Usually the logging of the CPU state produced by -d cpu is sufficient
>>> to diagnose problems, but sometimes you want to see the state of
>>> the floating point registers as well. We don't want to enable that
>>> by default as it adds a lot of extra data to the log; instead,
>>> allow it to be optionally enabled via -d fpu.
>>>
>>> Signed-off-by: Peter Maydell <address@hidden>
>>> ---
>>> I've found this helpful while tracking down fp-emulation related bugs.
>>>
>>> include/qemu/log.h | 1 +
>>> accel/tcg/cpu-exec.c | 9 ++++++---
>>> util/log.c | 2 ++
>>> 3 files changed, 9 insertions(+), 3 deletions(-)
>>
>> Reviewed-by: Richard Henderson <address@hidden>
>>
>> I'll also note that only i386 and arm check this flag;
>> something to fix for the rest...
>
> Mmm. It would also be nice not to have that TARGET_I386
> special case for CPU_DUMP_CCOP -- we should either care about
> that for everything, or for nothing (my vote would be for not
> printing it unless user-requested, since it's an internal
> tcg target detail.)
That's fine by me.
Paolo