[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] lm32: tcg_handle_interrupt: assertion failed: (qemu_mut

From: Paolo Bonzini
Subject: Re: [Qemu-devel] lm32: tcg_handle_interrupt: assertion failed: (qemu_mutex_iothread_locked())
Date: Wed, 9 May 2018 17:57:44 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0

On 09/05/2018 17:06, Michael Walle wrote:
>> All these calls into lm32_pic.c need to take the BQL.  They are all
>> wrong, but this one was unlucky (or lucky) enough to be caught.
>> Paolo
> my patch [1] from the beginning of this year just take the lock in
> op_helper.c.

Yes, I agree that's the best way to do it.

> The only other places are the gdbstub.c and
> lm32_cpu_dump_state(). So these are still missing, right?

Those should be called with BQL taken.


> -michael
> [1] http://lists.gnu.org/archive/html/qemu-devel/2018-01/msg01598.html

reply via email to

[Prev in Thread] Current Thread [Next in Thread]