Re: [Qemu-devel] [PATCH v1 1/1] tests/docker: Add a Avocado Docker test

[Alistair Francis]

On Tue, May 8, 2018 at 8:49 AM, Philippe Mathieu-Daudé <address@hidden> wrote:
> Hi Alistair,
>
> On 05/07/2018 09:02 PM, Philippe Mathieu-Daudé wrote:
>>> On 05/07/2018 05:09 PM, Alistair Francis wrote:
> [...]>>> +++ b/tests/docker/test-avocado
>>>> @@ -0,0 +1,28 @@
>>>> +#!/bin/bash -e
>>>> +#
>>>> +# Avocado tests on Fedora, as these are a real pain on Debian systems
>>>
>>> Have been here... Then used the git version :/
>>>
>>>> +#
>>>> +# Copyright (c) 2018 Western Digital.
>>>> +#
>>>> +# Authors:
>>>> +#  Alistair Francis <address@hidden>
>>>> +#
>>>> +# This work is licensed under the terms of the GNU GPL, version 2
>>>> +# or (at your option) any later version. See the COPYING file in
>>>> +# the top-level directory.
>>>> +#
>>>> +# Run this test: NETWORK=1 make address@hidden
>>>> +
>>>> +. common.rc
>>>> +
>>>> +requires avocado
>>>> +
>>>> +cd "$BUILD_DIR"
>>>> +
>>>> +DEF_TARGET_LIST="x86_64-softmmu"
>>>> +TARGET_LIST=${TARGET_LIST:-$DEF_TARGET_LIST} \
>>>> +build_qemu
>>>> +install_qemu
>>>> +export PATH="${PATH}:$(pwd)"
>>>> +avocado vt-bootstrap --yes-to-all --vt-type qemu
>>
>> Can we do the bootstrapping in the Dockerfile?
>>
>> Testing your image it download big files (i.e. JeOS image) in my
>> ~avocado/data/avocado-vt/images which is internal to the volatile docker
>> instance, so I have to download again each time I run the tests...
>
> Do we need this JeOS image?
>
> http://avocado-vt.readthedocs.io/en/latest/DownloadableImages.html#jeos-image

I think that is the one that is pulled in.

Alistair

>
>>
>> We need to pass this cache path to the docker instance.
>> For example the vm-test use ~/.cache/qemu-vm/download.
>>
>>>> +avocado run boot --vt-qemu-bin ./x86_64-softmmu/qemu-system-x86_64
>>>
>>> So this script is for the VT version, specific to x86. I'd rather name
>>> the script accordingly "test-avocado-vt".
>