[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/2] xen-hvm: use new resource mapping API
From: |
Paul Durrant |
Subject: |
Re: [Qemu-devel] [PATCH 0/2] xen-hvm: use new resource mapping API |
Date: |
Wed, 9 May 2018 16:05:37 +0000 |
> -----Original Message-----
> From: address@hidden [mailto:address@hidden
> Sent: 09 May 2018 17:02
> To: Paul Durrant <address@hidden>
> Cc: address@hidden; address@hidden; xen-
> address@hidden; Paul Durrant <address@hidden>
> Subject: Re: [Qemu-devel] [PATCH 0/2] xen-hvm: use new resource mapping
> API
>
> Hi,
>
> This series seems to have some coding style problems. See output below for
> more information:
>
> Type: series
> Message-id: address@hidden
> Subject: [Qemu-devel] [PATCH 0/2] xen-hvm: use new resource mapping
> API
>
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
>
> BASE=base
> n=1
> total=$(git log --oneline $BASE.. | wc -l)
> failed=0
>
> git config --local diff.renamelimit 0
> git config --local diff.renames True
> git config --local diff.algorithm histogram
>
> commits="$(git log --format=%H --reverse $BASE..)"
> for c in $commits; do
> echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
> if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -;
> then
> failed=1
> echo
> fi
> n=$((n+1))
> done
>
> exit $failed
> === TEST SCRIPT END ===
>
> Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
> From https://github.com/patchew-project/qemu
> * [new tag] patchew/20180509154604.25530-1-
> address@hidden -> patchew/20180509154604.25530-1-
> address@hidden
> * [new tag] patchew/20180509154849.27979-1-
> address@hidden -> patchew/20180509154849.27979-1-
> address@hidden
> * [new tag] patchew/address@hidden ->
> patchew/address@hidden
> Switched to a new branch 'test'
> 16691ff49e xen-hvm: try to use xenforeignmemory_map_resource() to map
> ioreq pages
> d4bcd68252 xen-hvm: create separate function for ioreq server initialization
>
> === OUTPUT BEGIN ===
> Checking PATCH 1/2: xen-hvm: create separate function for ioreq server
> initialization...
> Checking PATCH 2/2: xen-hvm: try to use
> xenforeignmemory_map_resource() to map ioreq pages...
> ERROR: spaces required around that '*' (ctx:WxV)
> #164: FILE: include/hw/xen/xen_common.h:128:
> + xenforeignmemory_handle *fmem, domid_t domid, unsigned int type,
> ^
>
> total: 1 errors, 0 warnings, 138 lines checked
>
> Your patch has style problems, please review. If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
This style warning appears to be spurious.
Paul
>
> === OUTPUT END ===
>
> Test command exited with code: 1
>
>
> ---
> Email generated automatically by Patchew [http://patchew.org/].
> Please send your feedback to address@hidden