qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 2/9] raw: Implement copy offloading


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v3 2/9] raw: Implement copy offloading
Date: Wed, 9 May 2018 10:17:25 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0

On 05/09/2018 09:58 AM, Fam Zheng wrote:
Just pass down to ->file.

Signed-off-by: Fam Zheng <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
---
  block/raw-format.c | 20 ++++++++++++++++++++
  1 file changed, 20 insertions(+)

diff --git a/block/raw-format.c b/block/raw-format.c
index a378547c99..febddf00c0 100644
--- a/block/raw-format.c
+++ b/block/raw-format.c
@@ -482,6 +482,24 @@ static int raw_probe_geometry(BlockDriverState *bs, 
HDGeometry *geo)
      return bdrv_probe_geometry(bs->file->bs, geo);
  }
+static int coroutine_fn raw_co_copy_range_from(BlockDriverState *bs,
+                                               BdrvChild *src, uint64_t 
src_offset,
+                                               BdrvChild *dst, uint64_t 
dst_offset,
+                                               uint64_t bytes, 
BdrvRequestFlags flags)
+{
+    return bdrv_co_copy_range_from(bs->file, src_offset, dst, dst_offset,
+                                   bytes, flags);

Bug - this fails to take into account s->offset, which occurs when opening a raw format protocol over a subset of the overall format protocol.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org



reply via email to

[Prev in Thread] Current Thread [Next in Thread]