Re: [Qemu-devel] [PATCH v12 12/21] migration: Add multifd traces for start/end thread

[Juan Quintela]

"Dr. David Alan Gilbert" <address@hidden> wrote:
> * Juan Quintela (address@hidden) wrote:
>> We want to know how many pages/packets each channel has sent.  Add
>> counters for those.
>> 
>> Signed-off-by: Juan Quintela <address@hidden>
>> ---
>>  migration/ram.c        | 20 ++++++++++++++++++++
>>  migration/trace-events |  4 ++++
>>  2 files changed, 24 insertions(+)

>>  typedef struct {
>> @@ -495,6 +499,10 @@ typedef struct {
>>      uint32_t flags;
>>      /* global number of generated multifd packets */
>>      uint32_t seq;
>> +    /* packets sent through this channel */
>> +    uint32_t num_packets;
>> +    /* pages sent through this channel */
>> +    uint32_t num_pages;
>
> Doesn't the comment for 'mutex' say 'protects the following parameters'
> (added in 09/21) ?  In which case....

This two are really local.  Fixing comment.

Thanks, Juan.