[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target/m68k: Fix build Werror with gcc 8.0.1
|
From: |
Laurent Vivier |
|
Subject: |
Re: [Qemu-devel] [PATCH] target/m68k: Fix build Werror with gcc 8.0.1 |
|
Date: |
Tue, 8 May 2018 22:42:24 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
Le 08/05/2018 à 20:55, Richard Henderson a écrit :
> Fedora 28 ships with the released gcc 8.
>
> The Werror stems from the compiler finding a path through the second
> switch via a missing default case in which src1 is uninitialized, and
> not being able to prove that the missing default case is unreachable
> due to the first switch.
>
> Simplify the second switch to merge default with OS_LONG,
> which returns directly. This removes the unreachable path.
>
> Cc: Laurent Vivier <address@hidden>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
> target/m68k/translate.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Reviewed-by: Laurent Vivier <address@hidden>