[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/5] linux-user: add sparc/sparc64 specific errn
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-devel] [PATCH 5/5] linux-user: add sparc/sparc64 specific errno |
Date: |
Tue, 8 May 2018 22:26:44 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
Le 08/05/2018 à 22:22, Max Filippov a écrit :
> On Tue, May 8, 2018 at 12:40 PM, Laurent Vivier <address@hidden> wrote:
>> Copied from linux/arch/sparc/include/uapi/asm/errno.h
>>
>> Signed-off-by: Laurent Vivier <address@hidden>
>> ---
>> linux-user/sparc/target_syscall.h | 203
>> ++++++++++++++++++++++++++++++++++++
>> linux-user/sparc64/target_syscall.h | 203
>> ++++++++++++++++++++++++++++++++++++
>> 2 files changed, 406 insertions(+)
>
> The changes are coming from single file, why duplicating them?
> Could they go into e.g. linux-user/sparc/target_errno.h, and get
> #included by both linux-user/sparc/target_syscall.h and
> linux-user/sparc64/target_syscall.h?
>
Yes, I was also thinking at something like that.
I did like that because in QEMU sparc and sparc64 use two different
directories whereas in linux they use the same one. Duplication seems to
be the rule...
I will do as you suggest in v2 of the series.
Thanks,
Laurent
- [Qemu-devel] [PATCH 0/5] linux-user: fix sparc32plus, Laurent Vivier, 2018/05/08
- [Qemu-devel] [PATCH 1/5] linux-user: define correct fcntl() values for sparc, Laurent Vivier, 2018/05/08
- [Qemu-devel] [PATCH 3/5] linux-user: update sparc/syscall_nr.h to linux header 4.16, Laurent Vivier, 2018/05/08
- [Qemu-devel] [PATCH 2/5] linux-user: fix flock/flock64 padding, Laurent Vivier, 2018/05/08
- [Qemu-devel] [PATCH 5/5] linux-user: add sparc/sparc64 specific errno, Laurent Vivier, 2018/05/08
- [Qemu-devel] [PATCH 4/5] linux-user: fix convertion of flock/flock64 l_type field, Laurent Vivier, 2018/05/08