[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v8 3/8] tests: Add migration xbzrle test
From: |
Juan Quintela |
Subject: |
Re: [Qemu-devel] [PATCH v8 3/8] tests: Add migration xbzrle test |
Date: |
Tue, 08 May 2018 17:16:06 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) |
"Dr. David Alan Gilbert" <address@hidden> wrote:
> * Juan Quintela (address@hidden) wrote:
>> Signed-off-by: Juan Quintela <address@hidden>
>> Reviewed-by: Peter Xu <address@hidden>
>> +
>> + migrate_set_parameter(from, "xbzrle-cache-size", "33554432");
>
> I still worry about the cache size relative to the size of memory we're
> actually changing in the test; I don't quite understand why it's turning
> out to get lots of hits.
I planned this as a smorke test. But what value do you have in mind?
> Also, xbzrle eats so much CPU we'll still have to watch out for the low
> end CPUs.
Any concrete suggestion?
My plan would have been to push on my next pull request:
Add migration precopy test
Add migration xbzrle test
Migration ppc now inlines its program
And put the rest of the patches with fixes for another review.
Later, Juan.