[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] softfloat: Handle default NaN mode after pickNa

From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH] softfloat: Handle default NaN mode after pickNaNMulAdd, not before
Date: Tue, 8 May 2018 14:59:15 +0100

On 8 May 2018 at 12:30, Alex Bennée <address@hidden> wrote:
> Peter Maydell <address@hidden> writes:
>> It is implementation defined whether a multiply-add of
>> (0,inf,qnan) or (inf,0,qnan) raises InvalidaOperation or
>> not, so we let the target-specific pickNaNMulAdd function
>> handle this. This means that we must do the "return the
>> default NaN in default NaN mode" check after the call,
>> not before. Correct the ordering, and restore the comment
>> from the old propagateFloat64MulAddNaN() that warned about
>> this corner case.
>> This fixes a regression from 2.11 for Arm guests where we would
>> incorrectly fail to set the Invalid flag for these cases.
>> Cc: address@hidden
>> Signed-off-by: Peter Maydell <address@hidden>
> Reviewed-by: Alex Bennée <address@hidden>
> Tested-by: Alex Bennée <address@hidden>

Thanks; applied to target-arm.next.

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]