[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-arm] [PATCH] hw/arm/iotkit.c: fix minor memory le
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [Qemu-arm] [PATCH] hw/arm/iotkit.c: fix minor memory leak |
Date: |
Tue, 8 May 2018 10:04:33 -0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 05/08/2018 06:16 AM, Peter Maydell wrote:
> ping for review?
>
> thanks
> -- PMM
>
> On 27 April 2018 at 12:01, Peter Maydell <address@hidden> wrote:
>> Coverity (CID1390573) spots that we forgot to free the
>> gpioname strings in a loop in the iotkit realize function.
>> Correct the error.
>>
>> This isn't a significant leak, because this function
>> only ever runs once.
>>
>> Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
>> ---
>> hw/arm/iotkit.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/hw/arm/iotkit.c b/hw/arm/iotkit.c
>> index c5f0a5b98a..234185e8f7 100644
>> --- a/hw/arm/iotkit.c
>> +++ b/hw/arm/iotkit.c
>> @@ -517,6 +517,7 @@ static void iotkit_realize(DeviceState *dev, Error
>> **errp)
>> qdev_get_gpio_in(DEVICE(&s->ppc_irq_orgate),
>> i));
>> qdev_connect_gpio_out_named(DEVICE(ppc), "irq", 0,
>> qdev_get_gpio_in(devs, 0));
>> + g_free(gpioname);
>> }
>>
>> iotkit_forward_sec_resp_cfg(s);
>> --
>> 2.17.0
>