Re: [Qemu-devel] [PATCH] hw/arm/iotkit.c: fix minor memory leak

[Peter Xu]

On Fri, Apr 27, 2018 at 12:01:37PM +0100, Peter Maydell wrote:
> Coverity (CID1390573) spots that we forgot to free the
> gpioname strings in a loop in the iotkit realize function.
> Correct the error.
> 
> This isn't a significant leak, because this function
> only ever runs once.
> 
> Signed-off-by: Peter Maydell <address@hidden>

I believe this even does not require ARM knowledges, so:

Reviewed-by: Peter Xu <address@hidden>

> ---
>  hw/arm/iotkit.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/arm/iotkit.c b/hw/arm/iotkit.c
> index c5f0a5b98a..234185e8f7 100644
> --- a/hw/arm/iotkit.c
> +++ b/hw/arm/iotkit.c
> @@ -517,6 +517,7 @@ static void iotkit_realize(DeviceState *dev, Error **errp)
>                                qdev_get_gpio_in(DEVICE(&s->ppc_irq_orgate), 
> i));
>          qdev_connect_gpio_out_named(DEVICE(ppc), "irq", 0,
>                                      qdev_get_gpio_in(devs, 0));
> +        g_free(gpioname);
>      }
>  
>      iotkit_forward_sec_resp_cfg(s);
> -- 
> 2.17.0
> 
> 

-- 
Peter Xu