[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 4/8] migration: Create socket-address paramet
From: |
Juan Quintela |
Subject: |
Re: [Qemu-devel] [PATCH v7 4/8] migration: Create socket-address parameter |
Date: |
Tue, 08 May 2018 09:50:43 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) |
"Dr. David Alan Gilbert" <address@hidden> wrote:
> * Juan Quintela (address@hidden) wrote:
>> It will be used to store the uri parameters. We want this only for
>> tcp, so we don't set it for other uris. We need it to know what port
>> is migration running.
>>
>> Signed-off-by: Juan Quintela <address@hidden>
>>
>> --
>>
>> This used to be uri parameter, but it has so many troubles to
>> reproduce that it don't just make sense.
>>
>> This used to be a port parameter. I was asked to move to
>> SocketAddress, done.
>> I also merged the setting of the migration tcp port in this one
>> because now I need to free the address, and this makes it easier.
>> This used to be x-socket-address with a single direction, now it is a
>> list of addresses.
>
> Is there a reason it's a parameter rather than just an entry in
> MigrationInfo?
Done.
I think that we *should* create a migration instance also on destination
side, it is so much different adding things one side than the other.
Later, Juan.
- Re: [Qemu-devel] [PATCH v7 4/8] migration: Create socket-address parameter,
Juan Quintela <=