[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 4/9] i386: Add new property to control cache
From: |
Moger, Babu |
Subject: |
Re: [Qemu-devel] [PATCH v7 4/9] i386: Add new property to control cache info |
Date: |
Mon, 7 May 2018 23:29:30 +0000 |
> -----Original Message-----
> From: Eduardo Habkost [mailto:address@hidden
> Sent: Monday, May 7, 2018 2:14 PM
> To: Moger, Babu <address@hidden>
> Cc: address@hidden; address@hidden; address@hidden;
> address@hidden; address@hidden; address@hidden;
> address@hidden; address@hidden; address@hidden
> Subject: Re: [Qemu-devel] [PATCH v7 4/9] i386: Add new property to control
> cache info
>
> On Thu, Apr 26, 2018 at 11:26:44AM -0500, Babu Moger wrote:
> > This will be used to control the cache information.
> > By default new information will be displayed. If user
> > passes "-cpu legacy-cache" then older information will
> > be displayed even if the hardware supports new information.
> > It will be "on" for machine type "pc-q35-2.10" for compatibility.
> >
> > Signed-off-by: Babu Moger <address@hidden>
> > Tested-by: Geoffrey McRae <address@hidden>
> > ---
> > include/hw/i386/pc.h | 4 ++++
> > target/i386/cpu.c | 1 +
> > target/i386/cpu.h | 5 +++++
> > 3 files changed, 10 insertions(+)
> >
> > diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
> > index ffee841..d904a3c 100644
> > --- a/include/hw/i386/pc.h
> > +++ b/include/hw/i386/pc.h
> > @@ -327,6 +327,10 @@ bool e820_get_entry(int, uint32_t, uint64_t *,
> uint64_t *);
> > .driver = "q35-pcihost",\
> > .property = "x-pci-hole64-fix",\
> > .value = "off",\
> > + },{\
> > + .driver = TYPE_X86_CPU,\
> > + .property = "legacy-cache",\
> > + .value = "on",\
> > },
> >
>
> Looks good, except that we now need pc-*-2.13 machines, and this
> should be moved to PC_COMPAT_2_12.
Ok. Sure. There is no PC_COMPAT_2_12 definition now. I will add it and include
this new property.
>
> Also, I suggest squashing this with patch 5/9, and applying it
> before patch 3/9.
Ok. Sure.
>
> --
> Eduardo