[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 01/13] target-openrisc: Write back result before
From: |
Stafford Horne |
Subject: |
Re: [Qemu-devel] [PATCH 01/13] target-openrisc: Write back result before FPE exception |
Date: |
Sat, 5 May 2018 14:19:22 +0900 |
User-agent: |
Mutt/1.9.2 (2017-12-15) |
On Thu, May 03, 2018 at 10:40:18PM -0700, Richard Henderson wrote:
> From: Richard Henderson <address@hidden>
>
> The architecture manual is unclear about this, but the or1ksim
> does writeback before the exception. This requires splitting
> the helpers in half, with the exception raised by the second.
I dont really see a problem with this, ccing bandvig who did a lot of the fpu
hardware implementation in mor1kx.
> Reviewed-by: Bastian Koppelmann <address@hidden>
> Signed-off-by: Richard Henderson <address@hidden>
Acked-by: Stafford Horne <address@hidden>
> ---
> target/openrisc/helper.h | 25 +++--
> target/openrisc/fpu_helper.c | 250
> +++++++++----------------------------------
> target/openrisc/translate.c | 101 ++++++++++-------
> 3 files changed, 125 insertions(+), 251 deletions(-)
>
- [Qemu-devel] [PATCH 00/13] target/openrisc: Convert to decodetree.py, Richard Henderson, 2018/05/04
- [Qemu-devel] [PATCH 02/13] target/openrisc: Start conversion to decodetree.py, Richard Henderson, 2018/05/04
- [Qemu-devel] [PATCH 03/13] target/openrisc: Convert branch insns, Richard Henderson, 2018/05/04
- [Qemu-devel] [PATCH 01/13] target-openrisc: Write back result before FPE exception, Richard Henderson, 2018/05/04
- Re: [Qemu-devel] [PATCH 01/13] target-openrisc: Write back result before FPE exception,
Stafford Horne <=
- [Qemu-devel] [PATCH 04/13] target/openrisc: Convert memory insns, Richard Henderson, 2018/05/04
- [Qemu-devel] [PATCH 05/13] target/openrisc: Convert remainder of dec_misc insns, Richard Henderson, 2018/05/04
- [Qemu-devel] [PATCH 08/13] target/openrisc: Convert dec_logic, Richard Henderson, 2018/05/04
- [Qemu-devel] [PATCH 06/13] target/openrisc: Convert dec_calc, Richard Henderson, 2018/05/04
- [Qemu-devel] [PATCH 09/13] target/openrisc: Convert dec_M, Richard Henderson, 2018/05/04