[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 07/67] display: use local path for local headers
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH 07/67] display: use local path for local headers |
Date: |
Fri, 4 May 2018 13:33:19 -0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 05/03/2018 04:50 PM, Michael S. Tsirkin wrote:
> When pulling in headers that are in the same directory as C file (as
> opposed to one in include/), we should use its relative path, without a
> directory. Directory based path works more or less by accident.
>
> Signed-off-by: Michael S. Tsirkin <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/display/bcm2835_fb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/display/bcm2835_fb.c b/hw/display/bcm2835_fb.c
> index 7eab927..3355f4c 100644
> --- a/hw/display/bcm2835_fb.c
> +++ b/hw/display/bcm2835_fb.c
> @@ -26,7 +26,7 @@
> #include "qemu/osdep.h"
> #include "qapi/error.h"
> #include "hw/display/bcm2835_fb.h"
> -#include "hw/display/framebuffer.h"
> +#include "framebuffer.h"
> #include "ui/pixel_ops.h"
> #include "hw/misc/bcm2835_mbox_defs.h"
> #include "qemu/log.h"
>
- Re: [Qemu-devel] [PATCH 04/67] s390x: drop an unused include, (continued)
[Qemu-devel] [PATCH 03/67] hppa: use local path for local headers, Michael S. Tsirkin, 2018/05/03
[Qemu-devel] [PATCH 06/67] trace: use local path for local headers, Michael S. Tsirkin, 2018/05/03
[Qemu-devel] [PATCH 07/67] display: use local path for local headers, Michael S. Tsirkin, 2018/05/03
- Re: [Qemu-devel] [PATCH 07/67] display: use local path for local headers,
Philippe Mathieu-Daudé <=
[Qemu-devel] [PATCH 09/67] ioapic: fix up includes, Michael S. Tsirkin, 2018/05/03
[Qemu-devel] [PATCH 01/67] block: use local path for local headers, Michael S. Tsirkin, 2018/05/03
[Qemu-devel] [PATCH 10/67] e1000e: use local path for local headers, Michael S. Tsirkin, 2018/05/03
[Qemu-devel] [PATCH 08/67] ide: use local path for local headers, Michael S. Tsirkin, 2018/05/03
[Qemu-devel] [PATCH 11/67] rocker: drop an unused include, Michael S. Tsirkin, 2018/05/03
[Qemu-devel] [PATCH 12/67] ppc: use local path for local headers, Michael S. Tsirkin, 2018/05/03
[Qemu-devel] [PATCH 13/67] vhost-scsi: drop an unused include, Michael S. Tsirkin, 2018/05/03