[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 01/10] qobject: Use qobject_to() instead of type cast
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PULL 01/10] qobject: Use qobject_to() instead of type cast |
Date: |
Fri, 4 May 2018 10:04:45 +0200 |
The proper way to convert from (abstract) QObject to a (concrete)
subtype is qobject_to(). Look for offenders that type cast instead:
$ git-grep '(Q[A-Z][a-z]* \*)'
hmp.c: qmp_device_add((QDict *)qdict, NULL, &err);
include/qapi/qmp/qobject.h: return (QObject *)obj;
qobject/qobject.c:static void (*qdestroy[QTYPE__MAX])(QObject *) = {
tests/check-qdict.c: dst = (QDict *)qdict_crumple(src, &error_abort);
The first two cast away const, the third isn't a type cast. Fix the
fourth.
Signed-off-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
---
tests/check-qdict.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/check-qdict.c b/tests/check-qdict.c
index 2e73c2f86e..08d4303e6a 100644
--- a/tests/check-qdict.c
+++ b/tests/check-qdict.c
@@ -657,7 +657,7 @@ static void qdict_crumple_test_empty(void)
src = qdict_new();
- dst = (QDict *)qdict_crumple(src, &error_abort);
+ dst = qobject_to(QDict, qdict_crumple(src, &error_abort));
g_assert_cmpint(qdict_size(dst), ==, 0);
--
2.13.6
- [Qemu-devel] [PULL 00/10] QAPI patches for 2018-05-04, Markus Armbruster, 2018/05/04
- [Qemu-devel] [PULL 07/10] qapi: add SysEmuTarget to "common.json", Markus Armbruster, 2018/05/04
- [Qemu-devel] [PULL 08/10] qapi: change the type of TargetInfo.arch from string to enum SysEmuTarget, Markus Armbruster, 2018/05/04
- [Qemu-devel] [PULL 03/10] qobject: use a QObjectBase_ struct, Markus Armbruster, 2018/05/04
- [Qemu-devel] [PULL 06/10] qapi: fill in CpuInfoFast.arch in query-cpus-fast, Markus Armbruster, 2018/05/04
- [Qemu-devel] [PULL 02/10] qobject: Ensure base is at offset 0, Markus Armbruster, 2018/05/04
- [Qemu-devel] [PULL 09/10] qapi: discriminate CpuInfoFast on SysEmuTarget, not CpuInfoArch, Markus Armbruster, 2018/05/04
- [Qemu-devel] [PULL 05/10] qobject: Modify qobject_ref() to return obj, Markus Armbruster, 2018/05/04
- [Qemu-devel] [PULL 01/10] qobject: Use qobject_to() instead of type cast,
Markus Armbruster <=
- [Qemu-devel] [PULL 10/10] qapi: deprecate CpuInfoFast.arch, Markus Armbruster, 2018/05/04
- [Qemu-devel] [PULL 04/10] qobject: Replace qobject_incref/QINCREF qobject_decref/QDECREF, Markus Armbruster, 2018/05/04
- Re: [Qemu-devel] [PULL 00/10] QAPI patches for 2018-05-04, Peter Maydell, 2018/05/04