[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] iotests: Repairing error during snapshot de
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] iotests: Repairing error during snapshot deletion |
Date: |
Tue, 1 May 2018 17:40:05 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 2018-04-30 18:01, Eric Blake wrote:
> On 04/28/2018 11:34 AM, Max Reitz wrote:
>> This adds a test for an I/O error during snapshot deletion, and maybe
>> more importantly, for how to repair the resulting image. If the
>> snapshot has been deleted before the error occurs, the only negative
>> result will be leaked clusters -- and those should be repairable with
>> qemu-img check -r leaks.
>>
>> Signed-off-by: Max Reitz <address@hidden>
>> ---
>> tests/qemu-iotests/217 | 89
>> ++++++++++++++++++++++++++++++++++++++++++++++
>> tests/qemu-iotests/217.out | 42 ++++++++++++++++++++++
>> tests/qemu-iotests/group | 1 +
>> 3 files changed, 132 insertions(+)
>> create mode 100755 tests/qemu-iotests/217
>> create mode 100644 tests/qemu-iotests/217.out
>>
>
>> +
>> +# Internal snapshots are (currently) impossible with refcount_bits=1
>> +_unsupported_imgopts 'refcount_bits=1[^0-9]'
>> +
>
> And even if they are made possible (by cloning clusters instead of
> incrementing refcounts), you STILL need a refcount > 1 to test the
> particular repair functionality just fixed.
Ah, right...
> Up to you if you want to reword that comment a bit.
Yes, will do. ("This test needs clusters with at least a refcount of 2
so that OFLAG_COPIED is not set. refcount_bits=1 is therefore
unsupported.")
> Reviewed-by: Eric Blake <address@hidden>
(As always,) thanks!
Max
signature.asc
Description: OpenPGP digital signature
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH 2/2] iotests: Repairing error during snapshot deletion,
Max Reitz <=