[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RFC PATCH v2 12/19] timer: remove replay clock probe in de
From: |
Pavel Dovgalyuk |
Subject: |
[Qemu-devel] [RFC PATCH v2 12/19] timer: remove replay clock probe in deadline calculation |
Date: |
Sat, 28 Apr 2018 15:37:37 +0300 |
User-agent: |
StGit/0.17.1-dirty |
Ciro Santilli reported that commit a5ed352596a8b7eb2f9acce34371b944ac3056c4
breaks the execution replay. It happens due to the probing the clock
for the new instances of iothread.
However, this probing was made in replay mode for the timer lists that
are empty.
This patch removes clock probing in replay mode.
It is an artifact of the old version with another thread model.
Signed-off-by: Pavel Dovgalyuk <address@hidden>
---
util/qemu-timer.c | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/util/qemu-timer.c b/util/qemu-timer.c
index 2ed1bf2..86bfe84 100644
--- a/util/qemu-timer.c
+++ b/util/qemu-timer.c
@@ -578,17 +578,10 @@ int64_t timerlistgroup_deadline_ns(QEMUTimerListGroup
*tlg)
{
int64_t deadline = -1;
QEMUClockType type;
- bool play = replay_mode == REPLAY_MODE_PLAY;
for (type = 0; type < QEMU_CLOCK_MAX; type++) {
if (qemu_clock_use_for_deadline(type)) {
- if (!play || type == QEMU_CLOCK_REALTIME) {
- deadline = qemu_soonest_timeout(deadline,
-
timerlist_deadline_ns(tlg->tl[type]));
- } else {
- /* Read clock from the replay file and
- do not calculate the deadline, based on virtual clock. */
- qemu_clock_get_ns(type);
- }
+ deadline = qemu_soonest_timeout(deadline,
+
timerlist_deadline_ns(tlg->tl[type]));
}
}
return deadline;
- [Qemu-devel] [RFC PATCH v2 04/19] replay: don't drain/flush bdrv queue while RR is working, (continued)
- [Qemu-devel] [RFC PATCH v2 04/19] replay: don't drain/flush bdrv queue while RR is working, Pavel Dovgalyuk, 2018/04/28
- [Qemu-devel] [RFC PATCH v2 03/19] replay: update docs for record/replay with block devices, Pavel Dovgalyuk, 2018/04/28
- [Qemu-devel] [RFC PATCH v2 08/19] replay: introduce info hmp/qmp command, Pavel Dovgalyuk, 2018/04/28
- [Qemu-devel] [RFC PATCH v2 06/19] qcow2: introduce icount field for snapshots, Pavel Dovgalyuk, 2018/04/28
- [Qemu-devel] [RFC PATCH v2 05/19] replay: finish record/replay before closing the disks, Pavel Dovgalyuk, 2018/04/28
- [Qemu-devel] [RFC PATCH v2 07/19] migration: introduce icount field for snapshots, Pavel Dovgalyuk, 2018/04/28
- [Qemu-devel] [RFC PATCH v2 09/19] replay: introduce breakpoint at the specified step, Pavel Dovgalyuk, 2018/04/28
- [Qemu-devel] [RFC PATCH v2 10/19] replay: implement replay-seek command to proceed to the desired step, Pavel Dovgalyuk, 2018/04/28
- [Qemu-devel] [RFC PATCH v2 11/19] replay: flush events when exitting, Pavel Dovgalyuk, 2018/04/28
- [Qemu-devel] [RFC PATCH v2 12/19] timer: remove replay clock probe in deadline calculation,
Pavel Dovgalyuk <=
- [Qemu-devel] [RFC PATCH v2 13/19] replay: refine replay-time module, Pavel Dovgalyuk, 2018/04/28
- [Qemu-devel] [RFC PATCH v2 14/19] translator: fix breakpoint processing, Pavel Dovgalyuk, 2018/04/28
- [Qemu-devel] [RFC PATCH v2 15/19] replay: flush rr queue before loading the vmstate, Pavel Dovgalyuk, 2018/04/28
- [Qemu-devel] [RFC PATCH v2 16/19] gdbstub: add reverse step support in replay mode, Pavel Dovgalyuk, 2018/04/28
- [Qemu-devel] [RFC PATCH v2 17/19] gdbstub: add reverse continue support in replay mode, Pavel Dovgalyuk, 2018/04/28
- [Qemu-devel] [RFC PATCH v2 18/19] replay: describe reverse debugging in docs/replay.txt, Pavel Dovgalyuk, 2018/04/28
- [Qemu-devel] [RFC PATCH v2 19/19] replay: allow loading any snapshots before recording, Pavel Dovgalyuk, 2018/04/28
- Re: [Qemu-devel] [RFC PATCH v2 00/19] reverse debugging, Ciro Santilli, 2018/04/30