Re: [Qemu-devel] [PATCH v2] checkpatch.pl: add common glib defines to typelist

[Paolo Bonzini]

On 25/04/2018 09:01, Peter Xu wrote:
> Otherwise it can warn this:
> 
>   ERROR: space prohibited between function name and open parenthesis '('
> 
> When with things like this:
> 
>   typedef gboolean (*it_tree_iterator)(ITValue start, ITValue end);
> 
> CC: Paolo Bonzini <address@hidden>
> CC: Stefan Hajnoczi <address@hidden>
> CC: "Daniel P. Berrangé" <address@hidden>
> CC: Markus Armbruster <address@hidden>
> CC: Vladimir Sementsov-Ogievskiy <address@hidden>
> CC: Fam Zheng <address@hidden>
> Signed-off-by: Peter Xu <address@hidden>
> ---
> v2:
> - add more missing glib types [Markus]
> ---
>  scripts/checkpatch.pl | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index d52207a3cc..4954150e87 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -266,6 +266,33 @@ our @typeList = (
>       qr{target_(?:u)?long},
>       qr{hwaddr},
>       qr{xml${Ident}},
> +     # Glib definitions
> +     qr{gchar},
> +     qr{gshort},
> +     qr{glong},
> +     qr{gint},
> +     qr{gboolean},
> +     qr{guchar},
> +     qr{gushort},
> +     qr{gulong},
> +     qr{guint},
> +     qr{gfloat},
> +     qr{gdouble},
> +     qr{gpointer},
> +     qr{gconstpointer},
> +     qr{gint8},
> +     qr{guint8},
> +     qr{gint16},
> +     qr{guint16},
> +     qr{gint32},
> +     qr{guint32},
> +     qr{gint64},
> +     qr{guint64},
> +     qr{gsize},
> +     qr{gssize},
> +     qr{goffset},
> +     qr{gintptr},
> +     qr{guintptr},
>  );
>  
>  # This can be modified by sub possible.  Since it can be empty, be careful
> 

Queued, thanks.

Paolo