Re: [Qemu-devel] [PATCH v6 06/11] tests: let qapi-schema tests detect allowed-in-preconfig

[Eric Blake]

On 04/27/2018 10:05 AM, Igor Mammedov wrote:
> use new allowed-in-preconfig parameter in tests.
> 
> Signed-off-by: Igor Mammedov <address@hidden>
> ---
>  tests/qapi-schema/doc-good.out          |  4 ++--
>  tests/qapi-schema/ident-with-escape.out |  2 +-
>  tests/qapi-schema/indented-expr.out     |  4 ++--
>  tests/qapi-schema/qapi-schema-test.out  | 20 ++++++++++----------
>  tests/qapi-schema/test-qapi.py          |  4 ++--
>  5 files changed, 17 insertions(+), 17 deletions(-)

Might also be worth adding a negative test, similar to oob-test.json, as
well as tweaking qapi-schema.json to have at least one command with the
property set to true...

> +++ b/tests/qapi-schema/qapi-schema-test.out
> @@ -16,7 +16,7 @@ object Empty1
>  object Empty2
>      base Empty1
>  command user_def_cmd0 Empty2 -> Empty2
> -   gen=True success_response=True boxed=False oob=False
> +   gen=True success_response=True boxed=False oob=False preconfig=False
>  enum QEnumTwo ['value1', 'value2']
>      prefix QENUM_TWO
>  object UserDefOne

...so that this file tests as much as possible independently from our
normal QMP schema.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

signature.asc
Description: OpenPGP digital signature