[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 2/5] qapi: add SysEmuTarget to "common.json"
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v3 2/5] qapi: add SysEmuTarget to "common.json" |
Date: |
Fri, 27 Apr 2018 14:53:04 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 04/27/2018 02:28 PM, Laszlo Ersek wrote:
> We'll soon need an enumeration type that lists all the softmmu targets
> that QEMU (the project) supports. Introduce @SysEmuTarget to
> "common.json".
>
> The enum constant @x86_64 doesn't match the QAPI convention of preferring
> hyphen ("-") over underscore ("_"). This is intentional; the @SysEmuTarget
> constants are supposed to produce QEMU executable names when stringified
> and appended to the "qemu-system-" prefix. Put differently, the
> replacement text of the TARGET_NAME preprocessor macro must be possible to
> look up in the list of (stringified) enum constants.
>
> Like other enum types, @SysEmuTarget too can be used for discriminator
> fields in unions. For the @i386 constant, a C-language union member called
> "i386" would be generated. On mingw build hosts, "i386" is a macro
> however. Add "i386" to "polluted_words" at once.
>
> Cc: "Daniel P. Berrange" <address@hidden>
> Cc: Eric Blake <address@hidden>
> Cc: Markus Armbruster <address@hidden>
> Signed-off-by: Laszlo Ersek <address@hidden>
> ---
>
> Notes:
> PATCHv3:
>
> - copy the suggested (shorter) Notes: wrt. underscore use in @x86_64 to
> the schema, and move the original (longer) schema Notes: to the commit
> message [Eric]
Thanks; that looks better.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v3 0/5] qapi: introduce the SysEmuTarget enumeration, Laszlo Ersek, 2018/04/27
- [Qemu-devel] [PATCH v3 3/5] qapi: change the type of TargetInfo.arch from string to enum SysEmuTarget, Laszlo Ersek, 2018/04/27
- [Qemu-devel] [PATCH v3 4/5] qapi: discriminate CpuInfoFast on SysEmuTarget, not CpuInfoArch, Laszlo Ersek, 2018/04/27
- [Qemu-devel] [PATCH v3 5/5] qapi: deprecate CpuInfoFast.arch, Laszlo Ersek, 2018/04/27
- [Qemu-devel] [PATCH v3 1/5] qapi: fill in CpuInfoFast.arch in query-cpus-fast, Laszlo Ersek, 2018/04/27
- [Qemu-devel] [PATCH v3 2/5] qapi: add SysEmuTarget to "common.json", Laszlo Ersek, 2018/04/27
- Re: [Qemu-devel] [PATCH v3 2/5] qapi: add SysEmuTarget to "common.json",
Eric Blake <=