[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [ARM/FDPIC v3 4/4] linux-user: ARM-FDPIC: Add support f
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [ARM/FDPIC v3 4/4] linux-user: ARM-FDPIC: Add support for signals for FDPIC targets |
Date: |
Fri, 27 Apr 2018 16:15:49 +0100 |
On 24 April 2018 at 08:28, Christophe Lyon <address@hidden> wrote:
> The FDPIC restorer needs to deal with a function descriptor, hence we
> have to extend 'retcode' such that it can hold the instructions needed
> to perform this.
>
> The restorer sequence uses the same thumbness as the exception
> handler (mainly to support Thumb-only architectures).
>
> Compared to v2: setup_return() now returns an error if the FDPIC
> function description isn't readable. Callers of setup_return() are
> updated to force_sigsegv in such cases.
>
> Co-Authored-By: Mickaël Guêné <address@hidden>
> Signed-off-by: Christophe Lyon <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
Can you fix up the minor nits in patch 3, and resend as an
entire series with all the patches and a cover letter, please?
thanks
-- PMM