Re: [Qemu-devel] [PULL 2/8] target/m68k: implement flognp1

[Peter Maydell]

On 9 March 2018 at 14:26, Laurent Vivier <address@hidden> wrote:
> Using a local m68k floatx80_lognp1()
> [copied from previous:
> Written by Andreas Grabher for Previous, NeXT Computer Emulator.]
>
> Signed-off-by: Laurent Vivier <address@hidden>
> Message-Id: <address@hidden>

> +floatx80 floatx80_lognp1(floatx80 a, float_status *status)
> +{

...

> +    if (aSign && aExp >= one_exp) {
> +        if (aExp == one_exp && aSig == one_sig) {
> +            float_raise(float_flag_divbyzero, status);
> +            packFloatx80(aSign, floatx80_infinity.high, 
> floatx80_infinity.low);

Hi; Coverity (CID1390587) points out that packFloatx80 doesn't
do anything except return a value which is here being thrown
away, making the call useless. Should this be maybe
"return packFloatx80(...)" ?

> +        }

thanks
-- PMM