Re: [Qemu-devel] [PULL 13/14] spice: add cursor_dmabuf support

[Peter Maydell]

On 12 March 2018 at 09:14, Gerd Hoffmann <address@hidden> wrote:
> Add support for cursor dmabufs.  qemu has to render the cursor for
> that, so in case a cursor is present qemu allocates a new dmabuf, blits
> the scanout, blends in the pointer and passes on the new dmabuf to
> spice-server.  Without cursor qemu continues to simply pass on the
> scanout dmabuf as-is.

> +        } else {
> +            trace_qemu_spice_gl_forward_dmabuf(ssd->qxl.id,
> +                                               dmabuf->width, 
> dmabuf->height);
> +            /* note: spice server will close the fd, so hand over a dup */
> +            spice_qxl_gl_scanout(&ssd->qxl, dup(dmabuf->fd),
> +                                 dmabuf->width, dmabuf->height,
> +                                 dmabuf->stride, dmabuf->fourcc, false);
> +        }

Coverity complains about this, because it doesn't know that
spice_qxl_gl_scanout() closes the fd it's passed. Is it
worth adding something to our coverity model to indicate this?
(Coverity complained in CID 1390616, which I have marked as a
false-positive for now.)

thanks
-- PMM