[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC v2 1/2] virtio: add pmem driver
From: |
Jeff Moyer |
Subject: |
Re: [Qemu-devel] [RFC v2 1/2] virtio: add pmem driver |
Date: |
Thu, 26 Apr 2018 08:27:41 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Dan Williams <address@hidden> writes:
> [ adding Jeff directly since he has also been looking at
> infrastructure to track when MAP_SYNC should be disabled ]
>
> On Wed, Apr 25, 2018 at 7:21 AM, Dan Williams <address@hidden> wrote:
>> On Wed, Apr 25, 2018 at 4:24 AM, Pankaj Gupta <address@hidden> wrote:
>>> This patch adds virtio-pmem driver for KVM
>>> guest.
>>
>> Minor nit, please expand your changelog line wrapping to 72 columns.
>>
>>>
>>> Guest reads the persistent memory range
>>> information from Qemu over VIRTIO and registers
>>> it on nvdimm_bus. It also creates a nd_region
>>> object with the persistent memory range
>>> information so that existing 'nvdimm/pmem'
>>> driver can reserve this into system memory map.
>>> This way 'virtio-pmem' driver uses existing
>>> functionality of pmem driver to register persistent
>>> memory compatible for DAX capable filesystems.
>>
>> We need some additional enabling to disable MAP_SYNC for this
enable to disable... I like it! ;-)
>> configuration. In other words, if fsync() is required then we must
>> disable the MAP_SYNC optimization. I think this should be a struct
>> dax_device property looked up at mmap time in each MAP_SYNC capable
>> ->mmap() file operation implementation.
Ideally, qemu (seabios?) would advertise a platform capabilities
sub-table that doesn't fill in the flush bits.
-Jeff
Re: [Qemu-devel] [RFC v2 1/2] virtio: add pmem driver, Michael S. Tsirkin, 2018/04/25
Re: [Qemu-devel] [RFC v2 1/2] virtio: add pmem driver, Stefan Hajnoczi, 2018/04/26
[Qemu-devel] [RFC v2 2/2] pmem: device flush over VIRTIO, Pankaj Gupta, 2018/04/25