[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 06/16] migration: add postcopy total blocktime in
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PULL 06/16] migration: add postcopy total blocktime into query-migrate |
Date: |
Thu, 26 Apr 2018 13:28:44 +0100 |
User-agent: |
Mutt/1.9.5 (2018-04-13) |
* Eric Blake (address@hidden) wrote:
> On 04/25/2018 03:03 PM, Dr. David Alan Gilbert (git) wrote:
> > From: Alexey Perevalov <address@hidden>
> >
> > Postcopy total blocktime is available on destination side only.
> > But query-migrate was possible only for source. This patch
> > adds ability to call query-migrate on destination.
> > To be able to see postcopy blocktime, need to request postcopy-blocktime
> > capability.
>
> This prerequisite command...
>
>
> > +++ b/qapi/migration.json
> > @@ -155,6 +155,13 @@
> > # @error-desc: the human readable error description string, when
> > # @status is 'failed'. Clients should not attempt to parse the
> > # error strings. (Since 2.7)
> > +#
> > +# @postcopy-blocktime: total time when all vCPU were blocked during
> > postcopy
> > +# live migration (Since 2.13)
> > +#
> > +# @postcopy-vcpu-blocktime: list of the postcopy blocktime per vCPU (Since
> > 2.13)
>
> ... should be documented here (something along the lines of "This field
> is only present if the postcopy-blocktime migration capability was enabled")
>
> > +#
> > +
> > #
>
> Why the blank line addition? More to include in your followup cleanup
> patch.
Again I'll fix those up.
Dave
> --
> Eric Blake, Principal Software Engineer
> Red Hat, Inc. +1-919-301-3266
> Virtualization: qemu.org | libvirt.org
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- [Qemu-devel] [PULL 01/16] migration: introduce postcopy-blocktime capability, (continued)
- [Qemu-devel] [PULL 01/16] migration: introduce postcopy-blocktime capability, Dr. David Alan Gilbert (git), 2018/04/25
- [Qemu-devel] [PULL 02/16] migration: add postcopy blocktime ctx into MigrationIncomingState, Dr. David Alan Gilbert (git), 2018/04/25
- [Qemu-devel] [PULL 05/16] migration: add blocktime calculation into migration-test, Dr. David Alan Gilbert (git), 2018/04/25
- [Qemu-devel] [PULL 08/16] migration: stop compression to allocate and free memory frequently, Dr. David Alan Gilbert (git), 2018/04/25
- [Qemu-devel] [PULL 07/16] migration: stop compressing page in migration thread, Dr. David Alan Gilbert (git), 2018/04/25
- [Qemu-devel] [PULL 09/16] migration: stop decompression to allocate and free memory frequently, Dr. David Alan Gilbert (git), 2018/04/25
- [Qemu-devel] [PULL 06/16] migration: add postcopy total blocktime into query-migrate, Dr. David Alan Gilbert (git), 2018/04/25
- [Qemu-devel] [PULL 15/16] migration: introduce save_normal_page(), Dr. David Alan Gilbert (git), 2018/04/25
- [Qemu-devel] [PULL 14/16] migration: move calling save_zero_page to the common place, Dr. David Alan Gilbert (git), 2018/04/25
- [Qemu-devel] [PULL 03/16] migration: calculate vCPU blocktime on dst side, Dr. David Alan Gilbert (git), 2018/04/25
- [Qemu-devel] [PULL 10/16] migration: detect compression and decompression errors, Dr. David Alan Gilbert (git), 2018/04/25
- [Qemu-devel] [PULL 12/16] migration: move some code to ram_save_host_page, Dr. David Alan Gilbert (git), 2018/04/25
- [Qemu-devel] [PULL 11/16] migration: introduce control_save_page(), Dr. David Alan Gilbert (git), 2018/04/25
- [Qemu-devel] [PULL 13/16] migration: move calling control_save_page to the common place, Dr. David Alan Gilbert (git), 2018/04/25
- [Qemu-devel] [PULL 16/16] migration: remove ram_save_compressed_page(), Dr. David Alan Gilbert (git), 2018/04/25
- Re: [Qemu-devel] [PULL 00/16] migration queue, Peter Maydell, 2018/04/26