[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 03/10] intel-iommu: add iommu lock
From: |
Emilio G. Cota |
Subject: |
Re: [Qemu-devel] [PATCH 03/10] intel-iommu: add iommu lock |
Date: |
Wed, 25 Apr 2018 12:26:58 -0400 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Wed, Apr 25, 2018 at 12:51:22 +0800, Peter Xu wrote:
> Add a per-iommu big lock to protect IOMMU status. Currently the only
> thing to be protected is the IOTLB cache, since that can be accessed
> even without BQL, e.g., in IO dataplane.
Is the added lock going to protect anything else beyond a g_hash_table?
If not, did you consider using qht instead of the lock + hash table?
It would give you lockless lookups as well as scalable updates.
[Sorry if my question isn't relevant, I am not familiar with
this code and just briefly skimmed over this series.]
Thanks,
Emilio
- [Qemu-devel] [PATCH 00/10] intel-iommu: nested vIOMMU, cleanups, bug fixes, Peter Xu, 2018/04/25
- [Qemu-devel] [PATCH 01/10] intel-iommu: send PSI always even if across PDEs, Peter Xu, 2018/04/25
- [Qemu-devel] [PATCH 02/10] intel-iommu: remove IntelIOMMUNotifierNode, Peter Xu, 2018/04/25
- [Qemu-devel] [PATCH 03/10] intel-iommu: add iommu lock, Peter Xu, 2018/04/25
- Re: [Qemu-devel] [PATCH 03/10] intel-iommu: add iommu lock,
Emilio G. Cota <=
- Re: [Qemu-devel] [PATCH 03/10] intel-iommu: add iommu lock, Jason Wang, 2018/04/27
- Re: [Qemu-devel] [PATCH 03/10] intel-iommu: add iommu lock, Peter Xu, 2018/04/27
- Re: [Qemu-devel] [PATCH 03/10] intel-iommu: add iommu lock, Tian, Kevin, 2018/04/27
- Re: [Qemu-devel] [PATCH 03/10] intel-iommu: add iommu lock, Peter Xu, 2018/04/27
- Re: [Qemu-devel] [PATCH 03/10] intel-iommu: add iommu lock, Tian, Kevin, 2018/04/27
- Re: [Qemu-devel] [PATCH 03/10] intel-iommu: add iommu lock, Jason Wang, 2018/04/27
- Re: [Qemu-devel] [PATCH 03/10] intel-iommu: add iommu lock, Peter Xu, 2018/04/27
- Re: [Qemu-devel] [PATCH 03/10] intel-iommu: add iommu lock, Jason Wang, 2018/04/27
- Re: [Qemu-devel] [PATCH 03/10] intel-iommu: add iommu lock, Peter Xu, 2018/04/27