Re: [Qemu-devel] [ANNOUNCE] QEMU 2.12.0-rc4 is now available

[Laszlo Ersek]

Hi Peter,

On 04/18/18 16:56, Michael Roth wrote:
> A note from the maintainer:
> 
>   Barring any reports of showstopper bugs, the plan is to release
>   2.12.0 with no further changes on Tuesday 24th April.

I just noticed two QAPI bugs introduced in 2.12, in the following two
commits:

(1) ca230ff33f89 ("qmp: add architecture specific cpu data for
query-cpus-fast", 2018-02-26)

This commit added @arch to @CpuInfoFast, but it failed to set the new
field to CPU_INFO_ARCH_OTHER in qmp_query_cpus_fast(), when TARGET_S390X
is not defined.

(2) 25fa194b7b11 ("RISC-V Build Infrastructure", 2018-03-07)

This commit added the @riscv enum constant to @CpuInfoArch (used in both
@CpuInfo and @CpuInfoFast -- the return types of the @query-cpus and
@query-cpus-fast commands, respectively), and assigned, in both return
structures, the @CpuInfoRISCV sub-structure to the new enum value.

However, qmp_query_cpus_fast() does not populate the sub-structure, when
TARGET_RISCV is defined; only qmp_query_cpus() does.

The fixes don't look complicated. Do you want to hold the release while
I post the fixes?

I don't think these bugs are "show stoppers". On the other hand, QAPI is
an external interface.

Thanks
Laszlo