[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] timer/aspeed: fix vmstate version id
From: |
Cédric Le Goater |
Subject: |
Re: [Qemu-devel] [PATCH] timer/aspeed: fix vmstate version id |
Date: |
Mon, 23 Apr 2018 13:35:56 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 |
>>> I think it's nice to at least do the "bump version" thing, so you
>>> get a (hopefully comprehensible) error rather than just wrong
>>> data if you do try a cross version migration,
>>
>> On that topic, the error message was :
>>
>> Missing section footer for aspeed.timerctrl
>>
>> which is not very comprehensible for a version mismatch issue.
>
> Was that before your patch?
yes.
> The VMSTATE fields in the structure have no metadata stored
> for them to be parsed with; if you send a different number
> of array entries to the number the destination receives you end
> up with a corrupt stream. Section footers are just a canary
> that tells you something went wrong in that devices data.
> It has no more information to give you a more detailed error.
OK. Thanks for the explanation.
C.